Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused time var in material scripts #485

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 3, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

The time param declared in the ogre2 material scripts are no longer used in the shaders.

Here are the corresponding shaders. You can see that there are no uniforms called time:

gpu_ray_1st_pass_fs.glsl - time removed in #388
depth_camera_fs.glsl - time was probably never used.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Nov 3, 2021
@iche033 iche033 mentioned this pull request Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #485 (af174df) into ign-rendering4 (478e755) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #485   +/-   ##
===============================================
  Coverage           55.95%   55.95%           
===============================================
  Files                 147      147           
  Lines               14119    14119           
===============================================
  Hits                 7900     7900           
  Misses               6219     6219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478e755...af174df. Read the comment docs.

@chapulina chapulina merged commit 46dd20a into ign-rendering4 Nov 4, 2021
@chapulina chapulina deleted the remove_unused_time_var branch November 4, 2021 00:34
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants