Minor tweaks to visual cloning #418
Conversation
Signed-off-by: Ian Chen <[email protected]>
| this->meshDescriptor.meshName = _copy.meshName; | ||
| this->meshDescriptor.subMeshName = _copy.subMeshName; | ||
| this->meshDescriptor.centerSubMesh = _copy.centerSubMesh; | ||
| this->meshDescriptor = _desc; |
There was a problem hiding this comment.
Does this also copy the pointer to the mesh? As we discussed offline, I thought that we wanted to ignore storing/keeping track of this pointer
There was a problem hiding this comment.
yeah I took another look at the implementation and looks like the common::Mesh pointer is managed by the common::MeshManager and the pointer remains valid for the duration of the simulation session so it maybe ok. I don't have a strong opinion on this though
There was a problem hiding this comment.
As long as the pointer is valid, I am fine with storing it. Since it's a pointer, it doesn't take up much memory anyways. I say go ahead and merge it!
Codecov Report
@@ Coverage Diff @@
## adlarkin/clone_visual #418 +/- ##
=========================================================
- Coverage 55.19% 55.18% -0.01%
=========================================================
Files 191 191
Lines 19351 19348 -3
=========================================================
- Hits 10681 10678 -3
Misses 8670 8670
Continue to review full report at Codecov.
|
chapulina
added
beta
Signed-off-by: Ian Chen [email protected]
Made a few minor tweaks to API and documentation