Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JointVisual axis head visibility #387

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

atharva-18
Copy link
Contributor

@atharva-18 atharva-18 commented Aug 24, 2021

Signed-off-by: Atharva Pusalkar [email protected]

🦟 Bug fix

Summary

Fixes a bug in the joint child axis visual whenever the parent arrow visual is updated, as mentioned in gazebosim/gz-sim#961 (comment)
screenshot

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@atharva-18 atharva-18 requested a review from iche033 as a code owner August 24, 2021 17:25
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 24, 2021
@atharva-18 atharva-18 mentioned this pull request Aug 24, 2021
8 tasks
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #387 (f301591) into main (3cbd121) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   58.59%   58.59%   -0.01%     
==========================================
  Files         174      174              
  Lines       17062    17064       +2     
==========================================
+ Hits         9998     9999       +1     
- Misses       7064     7065       +1     
Impacted Files Coverage Δ
include/ignition/rendering/base/BaseJointVisual.hh 81.86% <50.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbd121...f301591. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Just retriggered a couple of CI builds that seem to have failed due to unrelated reason.

@iche033 iche033 merged commit 04b2af1 into gazebosim:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants