Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing test failure with RTLD_NODELETE #1038

Closed
wants to merge 1 commit into from

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Aug 14, 2024

🦟 Bug fix

Alternative to #1033

Summary

From #1033:

The INTEGRATION_load_unload test crashes with ogre 1.x. The tests checks to see if the render engine can be loaded and unloaded in a thread (which is how gz sim runs the render engine). The crash happens on ubuntu 24.04 with the system debs, see #1007 for more info.

Instead of the approach from #1033, this uses the suggestion from #1033 (comment)

To test (also from #1033)

The INTEGRATION_load_unload test should now pass with ogre 1.x on Ubuntu 24.04 with the system ogre debs:

GZ_ENGINE_TO_TEST=ogre  ./build/gz-rendering9/bin/INTEGRATION_load_unload

gz-sim should no longer crash on exit:

gz sim -v 4 -r --iterations 5 -s sensors_demo.sdf --render-engine ogre

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 14, 2024
@scpeters scpeters marked this pull request as ready for review August 14, 2024 22:01
@scpeters scpeters requested a review from iche033 as a code owner August 14, 2024 22:01
@scpeters
Copy link
Member Author

we will use #1033

@scpeters scpeters closed this Aug 15, 2024
@scpeters scpeters deleted the scpeters/test_-RTLD_NODELETE branch August 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant