Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions and enums #1020

Merged
merged 2 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions ogre2/include/gz/rendering/ogre2/Ogre2GzOgreRenderingMode.hh
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,10 @@ namespace gz
{
/// \brief Normal rendering
GORM_NORMAL = 0,
IORM_NORMAL = 0, // TODO(CH3): Deprecated. Remove on tock.

/// \brief Render a solid color explicit per object.
/// Used by e.g. Segmentation camera mode
GORM_SOLID_COLOR = 1,
IORM_SOLID_COLOR = 1, // TODO(CH3): Deprecated. Remove on tock.

/// \brief Like GORM_SOLID_COLOR, but if CustomParameter 2u
/// is present, raw diffuse texture will be multiplied against
Expand All @@ -48,19 +46,10 @@ namespace gz
///
/// Used by thermal camera
GORM_SOLID_THERMAL_COLOR_TEXTURED = 2,
// TODO(CH3): Deprecated. Remove on tock.
IORM_SOLID_THERMAL_COLOR_TEXTURED = 2,

/// \brief Total number of rendering modes
GORM_COUNT = 3,
IORM_COUNT = 3, // TODO(CH3): Deprecated. Remove on tock.
};
// TODO(CH3): Deprecated. Remove on tock.
#ifdef _WIN32
using IgnOgreRenderingMode = GzOgreRenderingMode;
#else
using IgnOgreRenderingMode GZ_DEPRECATED(7) = GzOgreRenderingMode;
#endif
} // namespace GZ_RENDERING_VERSION_NAMESPACE
} // namespace rendering
} // namespace gz
Expand Down
11 changes: 0 additions & 11 deletions ogre2/include/gz/rendering/ogre2/Ogre2RenderEngine.hh
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,6 @@ namespace gz
/// \return a list of FSAA levels
public: std::vector<unsigned int> FSAALevels() const;

/// \brief Deprecated. Use SphericalClipMinDistance instead
public: Ogre2GzHlmsSphericalClipMinDistance GZ_DEPRECATED(7) &
HlmsCustomizations();

/// \brief Retrieves Hlms customizations for tweaking them
/// \return Ogre HLMS customizations
public: Ogre2GzHlmsSphericalClipMinDistance &SphericalClipMinDistance();
Expand All @@ -201,13 +197,6 @@ namespace gz
/// and see Ogre::GzHlmsPbs
/// \param[in] renderingMode
public: void SetGzOgreRenderingMode(GzOgreRenderingMode renderingMode);
// TODO(CH3): Deprecated. Remove on tock.
public:
inline void GZ_DEPRECATED(7) SetIgnOgreRenderingMode(
GzOgreRenderingMode renderingMode)
{
return SetGzOgreRenderingMode(renderingMode);
}

/// \internal
/// \brief Get a pointer to the Pbs listener that adds terra shadows.
Expand Down
2 changes: 1 addition & 1 deletion ogre2/src/Ogre2GpuRays.cc
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ void Ogre2LaserRetroMaterialSwitcher::passPreExecute(
//
// material may be a nullptr if we called setMaterial directly
// (i.e. it's not using Ogre2Material interface).
// In those cases we fallback to PBS in the current IORM mode.
// In those cases we fallback to PBS in the current GORM mode.
auto material = Ogre::MaterialManager::getSingleton().getByName(
subItem->getMaterial()->getName() + "_solid",
Ogre::ResourceGroupManager::DEFAULT_RESOURCE_GROUP_NAME);
Expand Down
2 changes: 1 addition & 1 deletion ogre2/src/Ogre2MaterialSwitcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ void Ogre2MaterialSwitcher::cameraPreRenderScene(
//
// material may be a nullptr if we called setMaterial directly
// (i.e. it's not using Ogre2Material interface).
// In those cases we fallback to PBS in the current IORM mode.
// In those cases we fallback to PBS in the current GORM mode.
auto material = Ogre::MaterialManager::getSingleton().getByName(
subItem->getMaterial()->getName() + "_solid",
Ogre::ResourceGroupManager::DEFAULT_RESOURCE_GROUP_NAME);
Expand Down
32 changes: 0 additions & 32 deletions ogre2/src/Ogre2RenderEngine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -873,19 +873,6 @@ void Ogre2RenderEngine::RegisterHlms()
{
const char *env = std::getenv("GZ_RENDERING_RESOURCE_PATH");

// TODO(CH3): Deprecated. Remove on tock.
if (!env)
{
env = std::getenv("IGN_RENDERING_RESOURCE_PATH");

if (env)
{
gzwarn << "Using deprecated environment variable "
<< "[IGN_RENDERING_RESOURCE_PATH]. Please use "
<< "[GZ_RENDERING_RESOURCE_PATH] instead." << std::endl;
}
}

std::string resourcePath = (env) ? std::string(env) :
gz::rendering::getResourcePath();

Expand Down Expand Up @@ -1077,19 +1064,6 @@ void Ogre2RenderEngine::CreateResources()
{
const char *env = std::getenv("GZ_RENDERING_RESOURCE_PATH");

// TODO(CH3): Deprecated. Remove on tock.
if (!env)
{
env = std::getenv("IGN_RENDERING_RESOURCE_PATH");

if (env)
{
gzwarn << "Using deprecated environment variable "
<< "[IGN_RENDERING_RESOURCE_PATH]. Please use "
<< "[GZ_RENDERING_RESOURCE_PATH] instead." << std::endl;
}
}

std::string resourcePath = (env) ? std::string(env) :
gz::rendering::getResourcePath();
// install path
Expand Down Expand Up @@ -1431,12 +1405,6 @@ std::vector<unsigned int> Ogre2RenderEngine::FSAALevels() const
return this->dataPtr->fsaaLevels;
}

/////////////////////////////////////////////////
Ogre2GzHlmsSphericalClipMinDistance& Ogre2RenderEngine::HlmsCustomizations()
{
return this->dataPtr->sphericalClipMinDistance;
}

/////////////////////////////////////////////////
Ogre2GzHlmsSphericalClipMinDistance& Ogre2RenderEngine::
SphericalClipMinDistance()
Expand Down
7 changes: 0 additions & 7 deletions ogre2/src/Ogre2RenderTarget.cc
Original file line number Diff line number Diff line change
Expand Up @@ -945,16 +945,9 @@ void Ogre2RenderTarget::RebuildMaterial()
//////////////////////////////////////////////////
// Ogre2RenderTexture
//////////////////////////////////////////////////
#ifndef _WIN32
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
Ogre2RenderTexture::Ogre2RenderTexture()
{
}
#ifndef _WIN32
#pragma GCC diagnostic pop
#endif

//////////////////////////////////////////////////
Ogre2RenderTexture::~Ogre2RenderTexture()
Expand Down
2 changes: 1 addition & 1 deletion ogre2/src/Ogre2SegmentationMaterialSwitcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ void Ogre2SegmentationMaterialSwitcher::cameraPreRenderScene(
//
// material may be a nullptr if we called setMaterial directly
// (i.e. it's not using Ogre2Material interface).
// In those cases we fallback to PBS in the current IORM mode.
// In those cases we fallback to PBS in the current GORM mode.
auto material = Ogre::MaterialManager::getSingleton().getByName(
subItem->getMaterial()->getName() + "_solid",
Ogre::ResourceGroupManager::DEFAULT_RESOURCE_GROUP_NAME);
Expand Down
4 changes: 2 additions & 2 deletions ogre2/src/Ogre2ThermalCamera.cc
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ void Ogre2ThermalCameraMaterialSwitcher::cameraPreRenderScene(
//
// material may be a nullptr if we called setMaterial directly
// (i.e. it's not using Ogre2Material interface).
// In those cases we fallback to PBS in the current IORM mode.
// In those cases we fallback to PBS in the current GORM mode.
auto material = Ogre::MaterialManager::getSingleton().getByName(
subItem->getMaterial()->getName() + "_solid",
Ogre::ResourceGroupManager::DEFAULT_RESOURCE_GROUP_NAME);
Expand Down Expand Up @@ -504,7 +504,7 @@ void Ogre2ThermalCameraMaterialSwitcher::cameraPreRenderScene(
//
// material may be a nullptr if we called setMaterial directly
// (i.e. it's not using Ogre2Material interface).
// In those cases we fallback to PBS in the current IORM mode.
// In those cases we fallback to PBS in the current GORM mode.
auto material = Ogre::MaterialManager::getSingleton().getByName(
subItem->getMaterial()->getName() + "_solid",
Ogre::ResourceGroupManager::DEFAULT_RESOURCE_GROUP_NAME);
Expand Down
Loading