Skip to content

Commit

Permalink
Remove tools/code_check and update codecov (#321)
Browse files Browse the repository at this point in the history
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
  • Loading branch information
chapulina and iche033 authored May 15, 2021
1 parent 55a35a7 commit d3eb5ca
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 5,884 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
id: ci
uses: ignition-tooling/action-ignition-ci@bionic
with:
codecov-token: ${{ secrets.CODECOV_TOKEN }}
codecov-enabled: true
focal-ci:
runs-on: ubuntu-latest
name: Ubuntu Focal CI
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ project(ignition-rendering3 VERSION 3.4.0)
# Find ignition-cmake
#============================================================================
# If you get an error at this line, you need to install ignition-cmake
find_package(ignition-cmake2 REQUIRED)
find_package(ignition-cmake2 2.8.0 REQUIRED)

#============================================================================
# Set up the project
Expand Down
111 changes: 0 additions & 111 deletions tools/check_test_ran.py

This file was deleted.

149 changes: 0 additions & 149 deletions tools/code_check.sh

This file was deleted.

Loading

1 comment on commit d3eb5ca

@darksylinc
Copy link
Contributor

@darksylinc darksylinc commented on d3eb5ca Jun 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit removed check_test_ran.py and now all check_INTEGRATION_* (Failed) in rendering5 tests are failing when running the tests locally.

Is this intended?

Edit: Ahhh nevermind, ign-cmake wasn't up to date.

Please sign in to comment.