Skip to content

Commit

Permalink
Disabling flaky depth and thermal camera tests on mac (#405) (#696)
Browse files Browse the repository at this point in the history
Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
  • Loading branch information
Crola1702 and iche033 authored Aug 1, 2022
1 parent ae5c491 commit c84a02d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 4 additions & 2 deletions test/integration/depth_camera.cc
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,10 @@ void DepthCameraTest::DepthCameraBoxes(
unsigned int ma = *mrgba >> 0 & 0xFF;
EXPECT_EQ(0u, mr);
EXPECT_EQ(0u, mg);
// Note: If it fails here, it may be this problem again:
#ifndef __APPLE__
// https://github.com/ignitionrobotics/ign-rendering/issues/332
EXPECT_GT(mb, 0u);
#endif

// Far left and right points should be red (background color)
float lc = pointCloudData[pcLeft + 3];
Expand Down Expand Up @@ -450,10 +451,11 @@ void DepthCameraTest::DepthCameraBoxes(
unsigned int a = *rgba >> 0 & 0xFF;
EXPECT_EQ(0u, r);
EXPECT_EQ(0u, g);
// Note: If it fails here, it may be this problem again:
#ifndef __APPLE__
// https://github.com/ignitionrobotics/ign-rendering/issues/332
EXPECT_GT(b, 0u);
EXPECT_EQ(255u, a);
#endif
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions test/integration/thermal_camera.cc
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,10 @@ void ThermalCameraTest::ThermalCameraBoxes(
for (unsigned int j = 0; j < thermalCamera->ImageWidth(); ++j)
{
float temp = thermalData[step + j] * linearResolution;
#ifndef __APPLE__
// https://github.com/ignitionrobotics/ign-rendering/issues/253
EXPECT_NEAR(boxTemp, temp, boxTempRange);
#endif
}
}

Expand Down

0 comments on commit c84a02d

Please sign in to comment.