Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find ign program instead of ignition-tools #57

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Re-enable UNIT_ign_TEST

Summary

The find_package(ignition-tools) call was removed in #56, but this disabled UNIT_ign_TEST. Instead, search for the ign program directly with find_program and adjust test logic accordingly.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

The find_package(ignition-tools) call was removed in gazebosim#56,
but this disabled UNIT_ign_TEST. Search for the ign
program directly and adjust test logic accordingly.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero August 19, 2021 04:57
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #57 (23cb74e) into ign-plugin1 (111ba95) will increase coverage by 4.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-plugin1      #57      +/-   ##
===============================================
+ Coverage        95.71%   99.82%   +4.10%     
===============================================
  Files               15       15              
  Lines              584      584              
===============================================
+ Hits               559      583      +24     
+ Misses              25        1      -24     
Impacted Files Coverage Δ
loader/src/ign.cc 96.00% <0.00%> (+96.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111ba95...23cb74e. Read the comment docs.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scpeters

@ahcorde ahcorde merged commit 752cda6 into gazebosim:ign-plugin1 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants