Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/code_check #52

Merged
merged 3 commits into from
May 13, 2021
Merged

Remove tools/code_check #52

merged 3 commits into from
May 13, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina requested review from ahcorde and mxgrey as code owners May 12, 2021 22:18
@chapulina chapulina changed the title Remove tools/code_check and update codecov Remove tools/code_check May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #52 (fbd02e9) into ign-plugin1 (225ac63) will not change coverage.
The diff coverage is n/a.

❗ Current head fbd02e9 differs from pull request most recent head 4bcb84f. Consider uploading reports for the commit 4bcb84f to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-plugin1      #52   +/-   ##
============================================
  Coverage        99.82%   99.82%           
============================================
  Files               15       15           
  Lines              584      584           
============================================
  Hits               583      583           
  Misses               1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225ac63...4bcb84f. Read the comment docs.

@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 12, 2021
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ign-cmake version on WIndows is

-- ignition-cmake2 version 2.0.0~pre4

But the required version is 2.8.0, do we need to release the package for this platform ?

@ahcorde
Copy link
Contributor

ahcorde commented May 13, 2021

@osrf-jenkins retest this please

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

do we need to release the package for this platform ?

Windows CI is building it from source, it should be fixed in 4bcb84f

@chapulina chapulina merged commit ccf671d into ign-plugin1 May 13, 2021
@chapulina chapulina deleted the chapulina/codecheck branch May 13, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants