Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable more ign tool functionality on windows #37

Closed
wants to merge 1 commit into from
Closed

Disable more ign tool functionality on windows #37

wants to merge 1 commit into from

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Feb 5, 2021

This is needed to fix downstream colcon builds on windows.

@scpeters
Disable more ign tool functionality on windows
17bd7ea 
This is needed to fix downstream colcon builds on windows.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from mxgrey as a code owner February 5, 2021 17:26
@scpeters scpeters requested a review from chapulina February 5, 2021 17:26
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Feb 5, 2021
@chapulina
Copy link
Contributor

Oh I just saw this PR, pushed a different fix in #38

I think we don't want to disable all of loader/src, right?

@scpeters
Copy link
Member Author

scpeters commented Feb 5, 2021

Oh I just saw this PR, pushed a different fix in #38

I think we don't want to disable all of loader/src, right?

the only thing in loader/src/CMakeLists.txt is adding the cmd subdirectory, so I just thought disabling it at the root would be more visible, but I'm fine with #38

@scpeters scpeters closed this Feb 5, 2021
@scpeters scpeters deleted the fix_windows branch February 5, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey Awaiting requested review from mxgrey

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina