Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameter name in DemangleSymbol to match declaration #117

Merged
merged 2 commits into from
May 10, 2023
Merged

Update parameter name in DemangleSymbol to match declaration #117

merged 2 commits into from
May 10, 2023

Conversation

shameekganguly
Copy link
Contributor

No description provided.

@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023 •
edited
Loading

Codecov Report

Merging #117 (0a4c170) into gz-plugin2 (410de69) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0a4c170 differs from pull request most recent head 97e3676. Consider uploading reports for the commit 97e3676 to get more accurate results

@@             Coverage Diff             @@
##           gz-plugin2     #117   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13
Impacted Files Coverage Δ
core/src/utility.cc 100.00% <100.00%> (ø)

azeey
azeey approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like windows CI has a warning, but I don't think it's caused by this PR.

@ahcorde ahcorde merged commit 7559c26 into gazebosim:gz-plugin2 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shameekganguly @azeey @ahcorde