Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix plugin header installation directory #104

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

methylDragon
Copy link
Contributor

Signed-off-by: methylDragon [email protected]

🦟 Bug fix

Fixes an erroneous install directive

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina
Copy link
Contributor

This should target gz-plugin2

@chapulina chapulina added bug Something isn't working ign to gz Renaming Ignition to Gazebo. Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #104 (0e39032) into gz-plugin2 (90f7466) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           gz-plugin2     #104   +/-   ##
===========================================
  Coverage       98.25%   98.25%           
===========================================
  Files              23       23           
  Lines             745      745           
===========================================
  Hits              732      732           
  Misses             13       13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@methylDragon methylDragon changed the base branch from main to gz-plugin2 August 17, 2022 19:14
@scpeters
Copy link
Member

should target gz-plugin2 as well

Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ch3/hotfix-installation-directory branch from 094943d to 0e39032 Compare August 17, 2022 19:15
@methylDragon
Copy link
Contributor Author

Retargeted

@methylDragon
Copy link
Contributor Author

That's weird.. it still isn't working

@scpeters
Copy link
Member

That's weird.. it still isn't working

it's failing to compile the gz-plugin2 branch. I think that job won't pass until we merge this

@scpeters scpeters merged commit daa9a65 into gz-plugin2 Aug 17, 2022
@scpeters scpeters deleted the ch3/hotfix-installation-directory branch August 17, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. bug Something isn't working ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants