Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define GZ_PHYSICS_VERSION_NAMESPACE in config.hh #597

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Feb 6, 2024

🦟 Bug fix

Part of gazebosim/gz-cmake#412

Summary

Ensure that the GZ_PHYSICS_VERSION_NAMESPACE macro is defined in config.hh.in.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7035e5) 77.91% compared to head (d4a2d1c) 77.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files         140      140           
  Lines        7766     7766           
=======================================
  Hits         6051     6051           
  Misses       1715     1715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters requested a review from j-rivero February 6, 2024 21:30
@scpeters scpeters merged commit 9d0542d into main Feb 6, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/version_namespace_macro branch February 6, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants