Merge 6 ➡️ 7 #594
Merged
Merge 6 ➡️ 7 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Steve Peters <[email protected]>
This cleans up physics tests in a few ways: Consolidate TestUtilities.hh and test/Utils.hh Move test headers to test/include/test Move mock headers to test/include/mock Create an INTERFACE library for test/mock headers that sets common compiler definitions as well as common libraries to link against Remove all instances of hardcoded world names or resource names and instead use constants. Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
looks like the include path for |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-physics7 #594 +/- ##
===============================================
- Coverage 77.83% 77.76% -0.08%
===============================================
Files 140 140
Lines 7772 7788 +16
===============================================
+ Hits 6049 6056 +7
- Misses 1723 1732 +9 ☔ View full report in Codecov by Sentry. |
scpeters
reviewed
Feb 6, 2024
include/gz/physics/config.hh.in
Outdated
| @@ -27,6 +27,7 @@ | |||
|
|
|||
| #define GZ_PHYSICS_VERSION "${PROJECT_VERSION}" | |||
| #define GZ_PHYSICS_VERSION_FULL "${PROJECT_VERSION_FULL}" | |||
| #define GZ_PHYSICS_VERSION_NAMESPACE v${PROJECT_VERSION_MAJOR} | |||
There was a problem hiding this comment.
the fact that this macro wasn't defined was a mistake, but defining it now changes ABI
There was a problem hiding this comment.
reported in gazebosim/gz-cmake#412
4 tasks
This reverts commit 1016539. Signed-off-by: Michael Carroll <[email protected]>
|
1016539 has been reverted, so let's sync with |
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
gz-launch6togz-launch7Branch comparison: gazebosim/gz-launch@gz-launch7...gz-launch6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)