-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up bullet memory use issues #539
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
…into mjcarroll/bullet_memory_issues
Signed-off-by: Michael Carroll <[email protected]>
af69f6b
to
62ac2bd
Compare
@scpeters I have tested this with clang/asan on Linux and verified that the errors that were there are gone. Can you give it a shot on macOS when you get a chance? |
Codecov Report
@@ Coverage Diff @@
## gz-physics6 #539 +/- ##
===============================================
+ Coverage 75.78% 75.83% +0.05%
===============================================
Files 143 143
Lines 7293 7325 +32
===============================================
+ Hits 5527 5555 +28
- Misses 1766 1770 +4
|
Signed-off-by: Michael Carroll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3fca39b
to
e4a12af
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Okay, I've finally reproduced this locally. I think installing all dependencies from homebrew might be a requirement. Backtrace
|
Signed-off-by: Addisu Z. Taddese <[email protected]>
Boom, look at that green. |
Signed-off-by: Addisu Z. Taddese <[email protected]>
nice work; this looks good, sorry I didn't get to it sooner |
Attempt at fixing various bullet shutdown issues and leaks.