Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable AABB tests for ellipsoids #506

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 12, 2023

🦟 Bug fix

Fixes #440

Summary

There were some uninitialized values that were used before #503 , so checking if we can re-enable AABB now that those are fixed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested review from mxgrey and scpeters as code owners April 12, 2023 16:50
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Apr 12, 2023
@azeey azeey requested a review from mjcarroll April 12, 2023 16:51
@azeey azeey self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #506 (d44b370) into gz-physics6 (c596af1) will not change coverage.
The diff coverage is n/a.

❗ Current head d44b370 differs from pull request most recent head 6add3ff. Consider uploading reports for the commit 6add3ff to get more accurate results

@@             Coverage Diff              @@
##           gz-physics6     #506   +/-   ##
============================================
  Coverage        75.52%   75.52%           
============================================
  Files              142      142           
  Lines             7191     7191           
============================================
  Hits              5431     5431           
  Misses            1760     1760           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey merged commit a720e1b into gazebosim:gz-physics6 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bullet-featherstone: Ellipse AABB returns invalid values on Focal
2 participants