Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS #43

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Add CODEOWNERS #43

merged 2 commits into from
Apr 28, 2020

Conversation

scpeters
Copy link
Member

I've added a CODEOWNERS file so that certain people will be automatically added as reviewers if a pull request touches certain parts of the code. This is an indication of investment but also a commitment to review relevant PR's in a timely manner. I'll @-mention the people I've nominated in this PR to see if they agree.

Signed-off-by: Steven Peters <[email protected]>
Copy link
Contributor

@claireyywang claireyywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@maryaB-osr maryaB-osr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve!

@scpeters scpeters self-assigned this Apr 27, 2020
@chapulina
Copy link
Contributor

There are many files which aren't covered by anyone. Should we assign someone to those? There could be people who get assigned to all PRs (*), or all folders and top-level files could be listed individually.

Copy link
Contributor

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to bump me to a general * code owner.

Signed-off-by: Steven Peters <[email protected]>
@scpeters
Copy link
Member Author

@mxgrey said: Feel free to bump me to a general * code owner.

I made you a * code owner in e8d2b5d

@scpeters scpeters merged commit 02b2612 into gazebosim:master Apr 28, 2020
@scpeters scpeters deleted the codeowners branch April 28, 2020 17:09
scpeters added a commit to scpeters/ign-physics that referenced this pull request Apr 30, 2020
Signed-off-by: Steven Peters <[email protected]>
scpeters added a commit to scpeters/ign-physics that referenced this pull request Apr 30, 2020
Signed-off-by: Steven Peters <[email protected]>
scpeters added a commit that referenced this pull request Apr 30, 2020
scpeters added a commit that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants