Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added world features common tests #414

Merged
merged 7 commits into from
Sep 12, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 5, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Related #372

Summary

Added world features common tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from mjcarroll September 5, 2022 16:11
@ahcorde ahcorde self-assigned this Sep 5, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #414 (b4438b1) into gz-physics6 (f177e02) will not change coverage.
The diff coverage is n/a.

❗ Current head b4438b1 differs from pull request most recent head 7480c98. Consider uploading reports for the commit 7480c98 to get more accurate results

@@             Coverage Diff              @@
##           gz-physics6     #414   +/-   ##
============================================
  Coverage        73.69%   73.69%           
============================================
  Files              128      128           
  Lines             5787     5787           
============================================
  Hits              4265     4265           
  Misses            1522     1522           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit b2a8bc4 into gz-physics6 Sep 12, 2022
@mjcarroll mjcarroll deleted the ahcorde/improved_common_test/world_features branch September 12, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants