Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved simulation features common tests #407

Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 30, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Related to Related to #372

Summary

Improved simulation features common tests

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Aug 30, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #407 (c518b60) into gz-physics6 (e36166d) will decrease coverage by 2.37%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           gz-physics6     #407      +/-   ##
===============================================
- Coverage        76.81%   74.44%   -2.38%     
===============================================
  Files              128      128              
  Lines             5737     5737              
===============================================
- Hits              4407     4271     -136     
- Misses            1330     1466     +136     
Impacted Files Coverage Δ
bullet/src/Base.hh 22.03% <0.00%> (-52.55%) ⬇️
bullet/src/SDFFeatures.cc 0.00% <0.00%> (-45.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll
Copy link
Contributor

Do we expect for overall coverage to go down here? I would think it would actually increase.

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 1, 2022

@mjcarroll

This decrease is because the bullet tests that I removed, I will increase the bullet coverage in follow up PRs

@mjcarroll mjcarroll merged commit 99a8c8e into gz-physics6 Sep 1, 2022
@mjcarroll mjcarroll deleted the ahcorde/improved_common_test/simulation_features branch September 1, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants