Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bullet StepForward feature implementation and added granular test #376

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 8, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Compared with other physics engines StepForward feature was not properly implement in bullet and bullet-featherstone.
This PR improves the implementation and adds a granular test

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from mjcarroll July 8, 2022 20:10
@ahcorde ahcorde requested review from azeey and mxgrey as code owners July 8, 2022 20:10
@ahcorde ahcorde self-assigned this Jul 8, 2022
@ahcorde ahcorde requested a review from scpeters as a code owner July 8, 2022 20:10
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #376 (29bc8de) into ahcorde/suggestions/373 (0f49f8e) will increase coverage by 1.61%.
The diff coverage is 82.43%.

@@                     Coverage Diff                     @@
##           ahcorde/suggestions/373     #376      +/-   ##
===========================================================
+ Coverage                    73.07%   74.68%   +1.61%     
===========================================================
  Files                          138      138              
  Lines                         6380     6448      +68     
===========================================================
+ Hits                          4662     4816     +154     
+ Misses                        1718     1632      -86     
Impacted Files Coverage Δ
bullet-featherstone/src/SimulationFeatures.cc 68.29% <68.42%> (+68.29%) ⬆️
bullet/src/SimulationFeatures.cc 94.87% <97.22%> (+94.87%) ⬆️
bullet/src/Base.hh 55.88% <0.00%> (+7.35%) ⬆️
bullet-featherstone/src/Base.hh 100.00% <0.00%> (+19.48%) ⬆️
bullet/src/SDFFeatures.cc 74.67% <0.00%> (+29.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f49f8e...29bc8de. Read the comment docs.

ahcorde added 2 commits July 11, 2022 14:36
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
@chapulina chapulina added the 🌱 garden Ignition Garden label Jul 11, 2022
@ahcorde ahcorde added the Bullet Bullet engine label Jul 15, 2022
…corde/add-bullet-featherstone/improve_stepforward
@ahcorde ahcorde merged commit 3d06752 into ahcorde/suggestions/373 Jul 19, 2022
@ahcorde ahcorde deleted the ahcorde/add-bullet-featherstone/improve_stepforward branch July 19, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants