Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Joint APIs for Parent/Child name #361

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to gazebosim/sdformat#1053.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested review from azeey and mxgrey as code owners June 21, 2022 00:26
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #361 (433a4d6) into main (a950315) will not change coverage.
The diff coverage is 43.75%.

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         128      128           
  Lines        5628     5628           
=======================================
  Hits         4196     4196           
  Misses       1432     1432           
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 62.71% <35.71%> (ø)
bullet/src/SDFFeatures.cc 45.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a950315...433a4d6. Read the comment docs.

@scpeters scpeters merged commit 9e7af39 into main Jun 21, 2022
@scpeters scpeters deleted the scpeters/rename_joint_apis branch June 21, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants