Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu Jammy CI #329

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Add Ubuntu Jammy CI #329

merged 2 commits into from
Mar 10, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 9, 2022

🦟 Bug fix

Part of gazebo-tooling/release-tools#566

Summary

Enable CI for Ubuntu 22.04 (Jammy)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #329 (3288ee8) into ign-physics5 (95e36b0) will not change coverage.
The diff coverage is n/a.

❗ Current head 3288ee8 differs from pull request most recent head 52ea9a2. Consider uploading reports for the commit 52ea9a2 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics5     #329   +/-   ##
=============================================
  Coverage         75.73%   75.73%           
=============================================
  Files               129      129           
  Lines              5762     5762           
=============================================
  Hits               4364     4364           
  Misses             1398     1398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e36b0...52ea9a2. Read the comment docs.

@mjcarroll
Copy link
Contributor

Probably good to go without waiting on Jenkins here.

@chapulina
Copy link
Contributor

Note that both DART and Bullet are being skipped on Jammy right now:

   -- Could NOT find DART (missing: DART_DIR)
  -- Looking for DART - not found
  
  -- Could NOT find Bullet (missing: BULLET_DYNAMICS_LIBRARY BULLET_COLLISION_LIBRARY BULLET_MATH_LIBRARY BULLET_SOFTBODY_LIBRARY BULLET_INCLUDE_DIR) 
  CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:55 (message):
     CONFIGURATION WARNINGS:
     -- Skipping component [dartsim]: Missing dependency [DART] (Components: collision-bullet, collision-ode, utils, utils-urdf).
        ^~~~~ Set SKIP_dartsim=true in cmake to suppress this warning.
     
     -- Skipping component [bullet]: Missing dependency [IgnBullet].
        ^~~~~ Set SKIP_bullet=true in cmake to suppress this warning.

@scpeters
Copy link
Member Author

scpeters commented Mar 9, 2022

Note that both DART and Bullet are being skipped on Jammy right now:

   -- Could NOT find DART (missing: DART_DIR)
  -- Looking for DART - not found
  
  -- Could NOT find Bullet (missing: BULLET_DYNAMICS_LIBRARY BULLET_COLLISION_LIBRARY BULLET_MATH_LIBRARY BULLET_SOFTBODY_LIBRARY BULLET_INCLUDE_DIR) 
  CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:55 (message):
     CONFIGURATION WARNINGS:
     -- Skipping component [dartsim]: Missing dependency [DART] (Components: collision-bullet, collision-ode, utils, utils-urdf).
        ^~~~~ Set SKIP_dartsim=true in cmake to suppress this warning.
     
     -- Skipping component [bullet]: Missing dependency [IgnBullet].
        ^~~~~ Set SKIP_bullet=true in cmake to suppress this warning.

good catch; we need to add a packages-jammy.apt file

@scpeters
Copy link
Member Author

scpeters commented Mar 9, 2022

Note that both DART and Bullet are being skipped on Jammy right now:

   -- Could NOT find DART (missing: DART_DIR)
  -- Looking for DART - not found
  
  -- Could NOT find Bullet (missing: BULLET_DYNAMICS_LIBRARY BULLET_COLLISION_LIBRARY BULLET_MATH_LIBRARY BULLET_SOFTBODY_LIBRARY BULLET_INCLUDE_DIR) 
  CMake Warning at /usr/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:55 (message):
     CONFIGURATION WARNINGS:
     -- Skipping component [dartsim]: Missing dependency [DART] (Components: collision-bullet, collision-ode, utils, utils-urdf).
        ^~~~~ Set SKIP_dartsim=true in cmake to suppress this warning.
     
     -- Skipping component [bullet]: Missing dependency [IgnBullet].
        ^~~~~ Set SKIP_bullet=true in cmake to suppress this warning.

good catch; we need to add a packages-jammy.apt file

added in 52ea9a2

@chapulina
Copy link
Contributor

The compiler warnings are already in ign-physics5:

https://build.osrfoundation.org/job/ignition_physics-ci-ign-physics5-focal-amd64/5/

@scpeters scpeters merged commit af01ef7 into ign-physics5 Mar 10, 2022
@scpeters scpeters deleted the jammy_ci branch March 10, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants