Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #291

Merged
merged 8 commits into from
Sep 10, 2021
Merged

3 ➡️ 4 #291

merged 8 commits into from
Sep 10, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-physics3 to ign-physics4

Branch comparison: ign-physics4...ign-physics3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

chapulina and others added 8 commits July 13, 2021 08:38
* 🎈 3.3.0

Signed-off-by: Louise Poubel <[email protected]>

* update date

Signed-off-by: Louise Poubel <[email protected]>
* Added DART feature for setting joint limits dynamically.

Signed-off-by: Martin Pecka <[email protected]>

* Make code compatible with older DART release (this commit can be reverted once newer DART is out).

Signed-off-by: Martin Pecka <[email protected]>

* Updated the number of models for test.

Signed-off-by: Martin Pecka <[email protected]>

* Apply suggestions from code review

Signed-off-by: Martin Pecka <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>

* Fixed issues from review.

Signed-off-by: Martin Pecka <[email protected]>

* Accomodate DART 6.9

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Since joints in DART are not considered frames, this adds dart::dynamics::SimpleFrame attached to the child body of a joint and offset from the child by the pose of the joint.

Signed-off-by: Addisu Z. Taddese <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from mxgrey as a code owner September 9, 2021 22:21
@chapulina chapulina requested a review from azeey September 9, 2021 22:21
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 9, 2021
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #291 (9c24242) into ign-physics4 (7960d50) will decrease coverage by 0.21%.
The diff coverage is 63.91%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics4     #291      +/-   ##
================================================
- Coverage         75.86%   75.65%   -0.22%     
================================================
  Files               125      125              
  Lines              5531     5627      +96     
================================================
+ Hits               4196     4257      +61     
- Misses             1335     1370      +35     
Impacted Files Coverage Δ
dartsim/src/JointFeatures.cc 63.56% <49.18%> (-4.46%) ⬇️
dartsim/src/KinematicsFeatures.cc 72.00% <50.00%> (-11.34%) ⬇️
dartsim/src/Base.hh 97.97% <100.00%> (+0.05%) ⬆️
include/ignition/physics/detail/Joint.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7960d50...9c24242. Read the comment docs.

@chapulina chapulina merged commit 77a6826 into ign-physics4 Sep 10, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch September 10, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants