API documentation common Set* features #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anindex <[email protected]>
Signed-off-by: anindex <[email protected]>
Signed-off-by: anindex <[email protected]>
Signed-off-by: anindex <[email protected]>
Signed-off-by: anindex <[email protected]>
Signed-off-by: anindex <[email protected]>
| /// analog to both `Link::SetWorldPose` and `Model::SetWorldPose`. | ||
| /// for FreeGroup is not well defined and difficult to implement | ||
| /// with generalized coordinates. The FreeGroup::SetWorldPose function should | ||
| /// provide an analog to both `Link::SetWorldPose` and `Model::SetWorldPose`. |
There was a problem hiding this comment.
We can remove the back ticks here since the previous Link::SetWorldPose didn't use them
include/ignition/physics/Joint.hh
Outdated
| @@ -103,6 +103,9 @@ namespace ignition | |||
| }; | |||
|
|
|||
| ///////////////////////////////////////////////// | |||
| /// \brief This feature sets the generalized Joint states such as | |||
| /// Position, Velocity, Acceleration of the Joint and the applied Force to | |||
There was a problem hiding this comment.
same comment about capitalization here
|
Btw there are some code check errors in the CI need to be addressed too https://github.com/ignitionrobotics/ign-physics/pull/165/checks?check_run_id=1400840714 |
Signed-off-by: anindex <[email protected]>
claireyywang
approved these changes
Dec 2, 2020
claireyywang
pushed a commit
that referenced
this pull request
Jan 7, 2021
* RemoveModelFromWorld doc * SetBasicJointState doc * SetJointVelocity doc * SetShape* doc * SetCylinderShapeProperties* doc * SetFreeGroupWorldPose and Velocity doc * Refine docs Co-authored-by: anindex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #9