Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bullet] Add ForwardStep feature #134

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Oct 19, 2020

Signed-off-by: Jorge Perez [email protected]

Connects to #44

@Blast545 Blast545 requested a review from Lobotuerk October 19, 2020 18:44
@Blast545 Blast545 self-assigned this Oct 19, 2020
@chapulina chapulina changed the title Add ForwardStep feature [Bullet] Add ForwardStep feature Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #134 into devel_bullet will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           devel_bullet     #134      +/-   ##
================================================
- Coverage         79.33%   79.21%   -0.12%     
================================================
  Files               112      113       +1     
  Lines              3993     3999       +6     
================================================
  Hits               3168     3168              
- Misses              825      831       +6     
Impacted Files Coverage Δ
bullet/src/SimulationFeatures.cc 0.00% <0.00%> (ø)
bullet/src/plugin.cc 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1a3f17...1e07ae4. Read the comment docs.

@Blast545 Blast545 force-pushed the devel/forward_step branch 2 times, most recently from d472294 to 099565f Compare October 21, 2020 21:00
@Blast545
Copy link
Contributor Author

Including this feature on its own was reporting a problem when trying to load the plugin on the ignition simulator, but after merging a92ad8a and 8fdfa0a and rebasing on top, including the feature seems to be working fine. @Lobotuerk PTAL

@Blast545 Blast545 marked this pull request as ready for review October 21, 2020 21:05
@Blast545 Blast545 requested a review from mxgrey as a code owner October 21, 2020 21:05
@Blast545 Blast545 requested a review from gonzodepedro October 21, 2020 21:05
Signed-off-by: Jorge Perez <[email protected]>
@Blast545 Blast545 merged commit 6576305 into devel_bullet Oct 22, 2020
@Blast545 Blast545 deleted the devel/forward_step branch October 22, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants