Skip to content

Commit

Permalink
Visibility fixes for DART on Windows (#711)
Browse files Browse the repository at this point in the history
* Set visibility for dartsim/src

Signed-off-by: Jose Luis Rivero <[email protected]>

* Need to include export headers

Signed-off-by: Jose Luis Rivero <[email protected]>

* Remove dartsim export in bullet headers

Signed-off-by: Jose Luis Rivero <[email protected]>

* Relocate export headers to match Harmonic

Signed-off-by: Jose Luis Rivero <[email protected]>

---------

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
  • Loading branch information
j-rivero and iche033 authored Jan 17, 2025
1 parent b7c1c9b commit 33be3ec
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion dartsim/src/EntityManagementFeatures.hh
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

#include <string>

#include <gz/physics/dartsim-plugin/Export.hh>

#include <gz/physics/ConstructEmpty.hh>
#include <gz/physics/Shape.hh>
#include <gz/physics/GetEntities.hh>
Expand All @@ -43,7 +45,7 @@ struct EntityManagementFeatureList : FeatureList<
WorldModelFeature
> { };

class EntityManagementFeatures :
class GZ_PHYSICS_DARTSIM_PLUGIN_VISIBLE EntityManagementFeatures :
public virtual Base,
public virtual Implements3d<EntityManagementFeatureList>
{
Expand Down
4 changes: 3 additions & 1 deletion dartsim/src/SDFFeatures.hh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#include <string>
#include <utility>

#include <gz/physics/dartsim-plugin/Export.hh>

#include <gz/physics/sdf/ConstructCollision.hh>
#include <gz/physics/sdf/ConstructJoint.hh>
#include <gz/physics/sdf/ConstructLink.hh>
Expand Down Expand Up @@ -50,7 +52,7 @@ struct SDFFeatureList : FeatureList<
sdf::ConstructSdfVisual
> { };

class SDFFeatures :
class GZ_PHYSICS_DARTSIM_PLUGIN_VISIBLE SDFFeatures :
public virtual EntityManagementFeatures,
public virtual Implements3d<SDFFeatureList>
{
Expand Down

0 comments on commit 33be3ec

Please sign in to comment.