Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 ➡️ 5 #74

Merged
merged 2 commits into from
Aug 4, 2020
Merged

4 ➡️ 5 #74

merged 2 commits into from
Aug 4, 2020
+23 −5

Conversation

chapulina
Copy link
Contributor

No description provided.

@chapulina
Add Focal CI (#73)
3f0b289 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
4 to 5
3317f2a 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner August 3, 2020 23:14
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited
Loading

Codecov Report

Merging #74 into ign-msgs5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs5      #74   +/-   ##
==========================================
  Coverage      85.66%   85.66%           
==========================================
  Files              7        7           
  Lines            795      795           
==========================================
  Hits             681      681           
  Misses           114      114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e877b...3317f2a. Read the comment docs.

caguero
caguero approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chapulina chapulina merged commit 457653b into ign-msgs5 Aug 4, 2020
@chapulina chapulina deleted the chapulina/4_to_5 branch August 4, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @caguero