Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 7 -> 8 #226

Merged
merged 12 commits into from
Mar 18, 2022
Merged

Merge 7 -> 8 #226

merged 12 commits into from
Mar 18, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 9, 2022

➡️ Forward port

Port ign-msgs7 to ign-msgs8

Branch comparison: ign-msgs8...ign-msgs7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@scpeters scpeters requested a review from caguero as a code owner March 9, 2022 21:15
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #226 (aab82d8) into ign-msgs8 (b41812f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-msgs8     #226   +/-   ##
==========================================
  Coverage      85.38%   85.38%           
==========================================
  Files              9        9           
  Lines            951      951           
==========================================
  Hits             812      812           
  Misses           139      139           
Impacted Files Coverage Δ
include/ignition/msgs/PointCloudPackedUtils.hh 84.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41812f...aab82d8. Read the comment docs.

@chapulina
Copy link
Contributor

It would be nice to include

@scpeters
Copy link
Member Author

It would be nice to include

merged in de7a3b8

@scpeters
Copy link
Member Author

this now includes the changes from 5.9.0 and 7.3.0

@scpeters scpeters merged commit 0d07350 into ign-msgs8 Mar 18, 2022
@scpeters scpeters deleted the merge78 branch March 18, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants