Marker: support different colors per point #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
The goal is to be able to display points with different colors. Right now, that's possible using one point per
Marker
message inside aMarker_V
, but that hurts performance because there's a lot of duplication on each nested message.The approach taken here is similar to the marker message on RViz.
Points only really need one color, they currently only use
diffuse
from thematerial
field. I decided to go with a fullMaterial
message instead of just a plain color because we may want to use this field for other things like triangles in the future.The branch is currently onRebased ontoign-msgs8
while I work on the implementation, but the goal is to merge this intomain
after gazebo-tooling/release-tools#554.main
.Test it
There's a demo on
ign-gui
:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸