Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Remove bitbucket-pipelines #175

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Fixes gazebo-tooling/release-tools#203

Summary

This will make CI run using Bionic for this branch, instead of Xenial, which is EOL.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

https://github.com/osrf/buildfarmer/issues/224

@chapulina
Copy link
Contributor Author

FYI, I updated the branch protections for ign-msgs[0-4] (i.e. pre-Citadel):

  • Don't require Focal, because that's not supported
  • Don't require Ubuntu, because there are unaddressed warnings

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reasons, there are a bunch of new warnings...

@chapulina chapulina added the Gazebo 9️ Dependency of Gazebo classic version 9 label Aug 24, 2021
@chapulina
Copy link
Contributor Author

For some reasons, there are a bunch of new warnings...

This is targeting ign-msgs1, which is the version used by Gazebo 9. I think we probably never cleaned up warnings for this branch, and I'm not sure if we want to put time into it now, so I just relaxed the branch protections for now.

@chapulina chapulina merged commit 277d997 into ign-msgs1 Aug 25, 2021
@chapulina chapulina deleted the chapulina/1/rm_bitbucket branch August 25, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gazebo 9️ Dependency of Gazebo classic version 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants