Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve updated codecheck issues #175

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Nov 4, 2020

This PR is meant to resolve new codecheck issues introduced by gazebosim/gz-cmake#117.

From my understanding, the plan is to forward port the fixes here to all other ignition versions once gazebosim/gz-cmake#117 is merged.

Signed-off-by: Ashton Larkin [email protected]

Signed-off-by: Ashton Larkin <[email protected]>
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #175 into ign-math6 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #175   +/-   ##
==========================================
  Coverage      99.22%   99.22%           
==========================================
  Files             59       59           
  Lines           5920     5920           
==========================================
  Hits            5874     5874           
  Misses            46       46           
Impacted Files Coverage Δ
src/Kmeans.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230ee79...ec66546. Read the comment docs.

@adlarkin
Copy link
Contributor Author

adlarkin commented Nov 4, 2020

I had to add // NOLINT to the do ... while loop in order to resolve a false positive from the new cpplint (it thought this was an empty loop):

https://github.com/ignitionrobotics/ign-math/blob/ec665461f4f9a557e00f0a912b0a4d56800f095e/src/Kmeans.cc#L152

@scpeters scpeters merged commit a72f761 into ign-math6 Nov 4, 2020
@scpeters scpeters deleted the adlarkin/cpplint_fixes branch November 4, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants