Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed repeated installation instructions (#147) #167

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Removed repeated installation instructions (#147) #167

merged 1 commit into from
Oct 19, 2020

Conversation

chapulina
Copy link
Contributor

Backport #147.

Added step to install dependencies from packages.apt, to resolve #100

@ahcorde @chapulina
Removed repeated installation instructions (#147)
18f70fd 
Added step to install dependencies from packages.apt

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 17, 2020
@chapulina chapulina mentioned this pull request Oct 17, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 17, 2020 •
edited
Loading

Codecov Report

Merging #167 into ign-math6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #167   +/-   ##
==========================================
  Coverage      99.22%   99.22%           
==========================================
  Files             59       59           
  Lines           5914     5914           
==========================================
  Hits            5868     5868           
  Misses            46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3597623...18f70fd. Read the comment docs.

ahcorde
ahcorde approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chapulina chapulina merged commit f8f7570 into ign-math6 Oct 19, 2020
@chapulina chapulina deleted the chapulina/6/147 branch October 19, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@maryaB-osr maryaB-osr Awaiting requested review from maryaB-osr

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @ahcorde