-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round, Rounded, Correct, Distance(x, y, z, w) and operator< addition to Vector 4 #146
Conversation
…to Vector4 Signed-off-by: Lucas Fernando <[email protected]>
I tried to test the
Should I change/remove the test? |
While working on #139 I noticed that the code checker would complain about Also another option may be to use std::nan(). |
Is a good option, I will check the result.
Looks like a more consistent test, I will let with this. |
Signed-off-by: Lucas Fernando <[email protected]>
With |
I don't think that you'll be able to get around the divide-by-zero issue either triggering the code check, compiler warning, or runtime error (since it's a signaling nan). I agree that using |
Great, the current PR is using just |
Resolves #71 .
This implements the functions
Round()
,Rounded()
,Correct()
,Distance(T x, T y, T z, T w)
and operator overloadoperator<(Vector4)
inVector4
API.It enables: