Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose headless_rendering sdf tag #148

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Feb 16, 2022

Signed-off-by: Aditya [email protected]
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #147

Summary

Exposes the --headless-rendering tag as a sdf tag : <headless_rendering>

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 16, 2022
@adityapande-1995 adityapande-1995 marked this pull request as ready for review February 16, 2022 18:30
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #148 (1fba16a) into ign-launch5 (26ef785) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-launch5     #148   +/-   ##
============================================
  Coverage        32.92%   32.92%           
============================================
  Files                4        4           
  Lines              817      817           
============================================
  Hits               269      269           
  Misses             548      548           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ef785...1fba16a. Read the comment docs.

@azeey
Copy link
Contributor

azeey commented Feb 24, 2022

I'm good with merging without a test since I don't know of a good/easy way to test this

@adityapande-1995 adityapande-1995 merged commit b63eb2e into ign-launch5 Feb 24, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/headless_rendering_tag branch February 24, 2022 19:51
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose --headless-rendering as a sdf tag to gazebo server plugin
3 participants