Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support <gz-gui> tag in plugin config #607

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 1, 2024

🎉 New feature

Summary

This allows users to specify <gz-gui> instead of <ignition-gui> in their GUI plugins so that SDF files can work on Fortress and Garden/Harmonic without modification.

Test it

Run PluginTest.GzSimCompatibility test

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from jennuine as a code owner February 1, 2024 23:55
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 1, 2024
@azeey
Copy link
Contributor Author

azeey commented Feb 2, 2024

Looks like the Focal failures are flaky tests. Windows failed due to infra issues. I'll retrigger it.

@azeey azeey merged commit ab5af59 into gazebosim:ign-gui6 Feb 2, 2024
9 of 11 checks passed
@azeey azeey deleted the support_gz branch February 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants