Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QImage's step size in ImageDisplay plugin #602

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix QImage's step size in ImageDisplay plugin #602

merged 1 commit into from
Dec 5, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 5, 2023

🦟 Bug fix

Fixes gazebosim/gz-rendering#945

Summary

The QImage constructor that was used expects the images are 32 bit aligned. This is not true for our RGB_INT8 formats. (24 bits) The PR fixes the issue by explicitly specifying the bytesPerLine field in the constructor.

Tested with camera_sensor.sdf world by changing the image width to be 321 (from 320)

Before
image_display_before

After
Image_display_after

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from jennuine as a code owner December 5, 2023 02:19
@iche033 iche033 changed the title Fix QImage's step size in image display Fix QImage's step size in ImageDisplay plugin Dec 5, 2023
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 5, 2023
@iche033
Copy link
Contributor Author

iche033 commented Dec 5, 2023

gz_gui-ci-pr_any-focal-amd64 test failures look unrelated.

@iche033 iche033 merged commit 5674c03 into ign-gui6 Dec 5, 2023
9 of 11 checks passed
@iche033 iche033 deleted the img_step branch December 5, 2023 20:47
@iche033 iche033 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @ahcorde