Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for vulkan support in rendering #589

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 16, 2023

🦟 Bug fix

Fixes #585

Summary

Add check to make sure we only enable vulkan only if gz-rendering is built with vulkan support.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from jennuine as a code owner October 16, 2023 22:40
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #589 (98e2f04) into gz-gui8 (872222a) will not change coverage.
The diff coverage is n/a.

❗ Current head 98e2f04 differs from pull request most recent head 99a8619. Consider uploading reports for the commit 99a8619 to get more accurate results

@@           Coverage Diff            @@
##           gz-gui8     #589   +/-   ##
========================================
  Coverage    68.09%   68.09%           
========================================
  Files           39       39           
  Lines         5372     5372           
========================================
  Hits          3658     3658           
  Misses        1714     1714           
Files Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc 57.73% <ø> (ø)

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 9b1b7b0 into gz-gui8 Oct 18, 2023
6 checks passed
@iche033 iche033 deleted the rendering_vulkan_check branch October 18, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants