-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes SpinBox for a TextField #572
Conversation
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-gui8 #572 +/- ##
========================================
Coverage 68.07% 68.07%
========================================
Files 38 38
Lines 5369 5369
========================================
Hits 3655 3655
Misses 1714 1714 |
Signed-off-by: Voldivh <[email protected]>
include/gz/gui/qml/GzSpinBox.qml
Outdated
import QtQuick.Controls 1.4 | ||
import QtQuick.Controls.Styles 1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, we should use the newer version of QtQuick Controls and remove the next line.
import QtQuick.Controls 1.4 | |
import QtQuick.Controls.Styles 1.4 | |
import QtQuick.Controls 2.15 |
Edit: I removed import QtQuick.Controls.Styles
since that won't be needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
include/gz/gui/qml/GzSpinBox.qml
Outdated
style: TextFieldStyle{ | ||
background: Rectangle { | ||
implicitWidth: 70 | ||
implicitHeight: 40 | ||
border.color: "gray" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TextField
from 2.15, doesn't have style. We'd just use background
instead:
style: TextFieldStyle{ | |
background: Rectangle { | |
implicitWidth: 70 | |
implicitHeight: 40 | |
border.color: "gray" | |
} | |
} | |
background: Rectangle { | |
implicitWidth: 70 | |
implicitHeight: 40 | |
border.color: "gray" | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Closing since #542 is no longer an issue. |
🦟 Bug fix
Fixes #542
Summary
Changes the implementation of GzSpinBox from a SpinBox to a TextField for MacOS.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.