Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes SpinBox for a TextField #572

Closed
wants to merge 7 commits into from
Closed

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Sep 20, 2023

🦟 Bug fix

Fixes #542

Summary

Changes the implementation of GzSpinBox from a SpinBox to a TextField for MacOS.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Voldivh Voldivh requested a review from azeey September 20, 2023 19:20
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #572 (dd9080e) into gz-gui8 (b3ed6bd) will not change coverage.
The diff coverage is n/a.

❗ Current head dd9080e differs from pull request most recent head f8332f8. Consider uploading reports for the commit f8332f8 to get more accurate results

@@           Coverage Diff            @@
##           gz-gui8     #572   +/-   ##
========================================
  Coverage    68.07%   68.07%           
========================================
  Files           38       38           
  Lines         5369     5369           
========================================
  Hits          3655     3655           
  Misses        1714     1714           

Comment on lines 18 to 19
import QtQuick.Controls 1.4
import QtQuick.Controls.Styles 1.4
Copy link
Contributor

@azeey azeey Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this, we should use the newer version of QtQuick Controls and remove the next line.

Suggested change
import QtQuick.Controls 1.4
import QtQuick.Controls.Styles 1.4
import QtQuick.Controls 2.15

Edit: I removed import QtQuick.Controls.Styles since that won't be needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment on lines 40 to 46
style: TextFieldStyle{
background: Rectangle {
implicitWidth: 70
implicitHeight: 40
border.color: "gray"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TextField from 2.15, doesn't have style. We'd just use background instead:

Suggested change
style: TextFieldStyle{
background: Rectangle {
implicitWidth: 70
implicitHeight: 40
border.color: "gray"
}
}
background: Rectangle {
implicitWidth: 70
implicitHeight: 40
border.color: "gray"
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@azeey
Copy link
Contributor

azeey commented Mar 14, 2024

Closing since #542 is no longer an issue.

@azeey azeey closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

GzSpinBox causes the Qt Scene Graph to crash on macOS
2 participants