Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin filter on Windows #567

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 3, 2023

🦟 Bug fix

Summary

On Windows, the plugin combobox in GUI was always empty (both in GUI alone and in GZ GUI). This PR fixes it.

It seems to me it 'd be beneficial if this logic was extracted as helper functions to gz-plugin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@peci1 peci1 requested a review from jennuine as a code owner September 3, 2023 17:23
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 3, 2023
@peci1 peci1 changed the base branch from gz-gui7 to gz-gui8 September 3, 2023 17:23
src/MainWindow.cc Outdated Show resolved Hide resolved
Co-authored-by: Silvio Traversaro <[email protected]>
Signed-off-by: Martin Pecka <[email protected]>
@peci1 peci1 force-pushed the fix-plugin-filter-win branch from d5f2da9 to 937583c Compare September 4, 2023 06:23
Signed-off-by: Martin Pecka <[email protected]>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #567 (a4cef4a) into gz-gui8 (e898137) will decrease coverage by 1.96%.
The diff coverage is 100.00%.

❗ Current head a4cef4a differs from pull request most recent head 15ee40f. Consider uploading reports for the commit 15ee40f to get more accurate results

@@             Coverage Diff             @@
##           gz-gui8     #567      +/-   ##
===========================================
- Coverage    70.06%   68.11%   -1.96%     
===========================================
  Files           39       39              
  Lines         5359     5375      +16     
===========================================
- Hits          3755     3661      -94     
- Misses        1604     1714     +110     
Files Coverage Δ
src/Application.cc 84.21% <100.00%> (+0.07%) ⬆️
src/MainWindow.cc 95.69% <100.00%> (+0.01%) ⬆️

... and 33 files with indirect coverage changes

src/Application.cc Outdated Show resolved Hide resolved
Co-authored-by: Silvio Traversaro <[email protected]>
Signed-off-by: Martin Pecka <[email protected]>
src/MainWindow.cc Outdated Show resolved Hide resolved
@azeey azeey requested a review from iche033 September 18, 2023 18:48
@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@mjcarroll mjcarroll merged commit 2759bff into gazebosim:gz-gui8 Nov 10, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants