Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #382

Merged
merged 11 commits into from
Apr 5, 2022
Merged

5 ➡️ 6 #382

merged 11 commits into from
Apr 5, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gui5 to ign-gui6

Branch comparison: ign-gui6...ign-gui5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

jennuine and others added 11 commits January 31, 2022 18:07
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from jennuine as a code owner April 5, 2022 15:27
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #382 (3f7f361) into ign-gui6 (a2497cb) will decrease coverage by 0.10%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##           ign-gui6     #382      +/-   ##
============================================
- Coverage     65.58%   65.48%   -0.11%     
============================================
  Files            39       39              
  Lines          5143     5157      +14     
============================================
+ Hits           3373     3377       +4     
- Misses         1770     1780      +10     
Impacted Files Coverage Δ
include/ignition/gui/MainWindow.hh 100.00% <ø> (ø)
src/plugins/screenshot/Screenshot.cc 30.12% <0.00%> (-3.22%) ⬇️
src/plugins/teleop/Teleop.cc 83.19% <37.50%> (-1.77%) ⬇️
src/plugins/image_display/ImageDisplay.cc 30.95% <66.66%> (+0.87%) ⬆️
src/Application.cc 85.47% <100.00%> (+0.12%) ⬆️
src/plugins/scene3d/Scene3D.cc 49.62% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2497cb...3f7f361. Read the comment docs.

@chapulina chapulina merged commit eac2fc2 into ign-gui6 Apr 5, 2022
@chapulina chapulina deleted the chapulina/5_to_6 branch April 5, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants