Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash on MacOS #155

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Avoid crash on MacOS #155

merged 1 commit into from
Dec 14, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Dec 10, 2020

While I was debugging this issue #145 I found this segfault on MacOS.

Signed-off-by: ahcorde [email protected]

@ahcorde
Avoid crash on MacOS
c540bb3 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added the bug Something isn't working label Dec 10, 2020
@ahcorde ahcorde requested a review from chapulina December 10, 2020 23:08
@ahcorde ahcorde self-assigned this Dec 10, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 10, 2020
@ahcorde ahcorde mentioned this pull request Dec 10, 2020
Open
@codecov
Copy link

codecov bot commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #155 (c540bb3) into ign-gui4 (cc8d8e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui4     #155   +/-   ##
=========================================
  Coverage     60.92%   60.92%           
=========================================
  Files            21       21           
  Lines          2751     2751           
=========================================
  Hits           1676     1676           
  Misses         1075     1075
Impacted Files Coverage Δ
src/plugins/scene3d/Scene3D.cc 12.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc8d8e6...c540bb3. Read the comment docs.

@chapulina chapulina added the macOS macOS support label Dec 14, 2020
chapulina
chapulina approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina chapulina merged commit 19f9dae into ign-gui4 Dec 14, 2020
@chapulina chapulina deleted the ahcorde/crash/macos branch December 14, 2020 18:37
@chapulina chapulina mentioned this pull request Jan 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@ahcorde ahcorde

Labels
bug Something isn't working 🔮 dome Ignition Dome macOS macOS support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @chapulina