Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config.yaml file from default cache location, if it exists #410

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 8, 2024

🎉 New feature

Summary

This reads the config.yaml or config.yml file from the cache directory when the ClientConfig is created. Without this change, a user needs to enter the -c command line argument each time or manually call the LoadConfig function.

Test it

  1. Create an API key from app.gazebosim.org
  2. Create a config.yaml file in ~/.gz/fuel that contains:
---
servers:
  -
    url: https://fuel.gazebosim.org
    private-token: YOUR_API_KEY
  1. Download a private model with something like gz fuel download -u https://fuel.gazebosim.org/1.0/OWNER/models/MODEL.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 8, 2024
@nkoenig nkoenig changed the base branch from gz-fuel-tools9 to gz-fuel-tools8 April 8, 2024 19:14
@nkoenig nkoenig force-pushed the nkoenig/use-private-token-in-config branch from 70c1044 to 34258eb Compare April 8, 2024 19:15
@nkoenig
Copy link
Contributor Author

nkoenig commented Apr 9, 2024

Tests are failing due to the fuel server instance.

@nkoenig nkoenig merged commit 6cbce88 into gz-fuel-tools8 Apr 9, 2024
4 of 9 checks passed
@nkoenig nkoenig deleted the nkoenig/use-private-token-in-config branch April 9, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants