-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support editing/patching model files #140
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #140 +/- ##
===================================================
+ Coverage 77.30% 78.55% +1.24%
===================================================
Files 19 19
Lines 2560 2583 +23
===================================================
+ Hits 1979 2029 +50
+ Misses 581 554 -27
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that testing a successful edit would be complicated, but maybe we could at least add some tests for some of the failure modes, to cover part of the code.
Signed-off-by: Nate Koenig <[email protected]>
Some tests added in e3ae7d8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍
One weird thing I ran into was that I forgot to pass -u
to the edit command, and I got this error message:
Invalid URL: only models can be edited right now.
I think we could catch the missing URL earlier.
Signed-off-by: Nate Koenig <[email protected]>
Added early catch in aa8250c. |
* Use lowercase resource and owner names when storing assets on disk (#130) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <[email protected]> * Remove added diff text from merge Signed-off-by: John Shepherd <[email protected]> * change model version in test back Signed-off-by: John Shepherd <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> * Fix more windows tests Signed-off-by: Nate Koenig <[email protected]> * Testing another windows fix Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> * Prepare for 3.5.0 release (#135) * Prepare for 3.5.0 release Signed-off-by: Nate Koenig <[email protected]> * Update Changelog.md Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> * Download model dependencies (#123) Signed-off-by: John Shepherd <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 4.3.0 release (#139) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Set keep alive on (#141) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Support editing/patching model files (#140) * Support editing/patching model files Signed-off-by: Nate Koenig <[email protected]> * Added documentation Signed-off-by: Nate Koenig <[email protected]> * Set keep alive on Signed-off-by: Nate Koenig <[email protected]> * Documentation and tests Signed-off-by: Nate Koenig <[email protected]> * One more test and exit catch missing -u Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Prepare for 5.1.0 release (#145) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> * Fix light map URI (#146) Signed-off-by: Ian Chen <[email protected]> * Bump to 5.1.1 (#147) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]> Co-authored-by: Ian Chen <[email protected]>
This allows an
edit
command to change a model's files, metadata, tags, etc.Example usage:
Signed-off-by: Nate Koenig [email protected]