4 to 5 11302020 #138
Merged
4 to 5 11302020 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Use lowercase resource and owner names when storing assets on disk Signed-off-by: Nate Koenig <[email protected]> * Remove added diff text from merge Signed-off-by: John Shepherd <[email protected]> * change model version in test back Signed-off-by: John Shepherd <[email protected]> * Fix test Signed-off-by: Nate Koenig <[email protected]> * Fix windows Signed-off-by: Nate Koenig <[email protected]> * Fix more windows tests Signed-off-by: Nate Koenig <[email protected]> * Testing another windows fix Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: John Shepherd <[email protected]>
* Prepare for 3.5.0 release Signed-off-by: Nate Koenig <[email protected]> * Update Changelog.md Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: John Shepherd <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
suggested changes
Dec 1, 2020
|
|
||
| // Check the dependency is cached | ||
| Result res5 = client.CachedModel(depUrl, cachedPath); | ||
| EXPECT_TRUE(res5); |
There was a problem hiding this comment.
These tests are failing:
/github/workspace/src/FuelClient_TEST.cc:568: Failure
Value of: res5
Actual: false
Expected: true
/github/workspace/src/FuelClient_TEST.cc:569: Failure
Expected equality of these values:
Result(ResultType::FETCH_ALREADY_EXISTS)
Which is: 1
res5
Which is: 0
There was a problem hiding this comment.
We need a new release of ign-msgs6:gazebosim/gz-msgs#104
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
|
@osrf-jenkins run tests please |
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools5 #138 +/- ##
===================================================
+ Coverage 76.54% 76.70% +0.16%
===================================================
Files 19 19
Lines 2554 2576 +22
===================================================
+ Hits 1955 1976 +21
- Misses 599 600 +1
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.