👩🌾 Fix Windows build #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
bug
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools3 #103 +/- ##
===================================================
+ Coverage 86.04% 86.08% +0.03%
===================================================
Files 18 19 +1
Lines 2215 2221 +6
===================================================
+ Hits 1906 1912 +6
Misses 309 309
Continue to review full report at Codecov.
|
azeey
approved these changes
Aug 18, 2020
| @@ -164,3 +164,10 @@ TEST(CollectionIdentifier, AsPrettyString) | |||
| EXPECT_NE(str.find("raspberry"), std::string::npos); | |||
| } | |||
| } | |||
|
|
|||
| ////////////////////////////////////////////////// | |||
| int main(int argc, char **argv) | |||
There was a problem hiding this comment.
Just curious, is it necessary to have the main here?
There was a problem hiding this comment.
Nope, it was just one of the things I tried. It follows the same pattern as ModelIdentifier and WorldIdentifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows build was broken on #98.
The problem was using a class that doesn't have a default constructor inside a future:
https://github.com/ignitionrobotics/ign-fuel-tools/blob/2eb0ee784c0c795289dd34e64ff2b814f9cc64c8/src/ign.cc#L611
I tried a few different things but ended up just giving the class a default constructor, which I don't think is unreasonable.