Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm test #463

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Fix arm test #463

merged 2 commits into from
Oct 19, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 18, 2022

🦟 Bug fix

Summary

Fix test for ARM systems.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 2 commits October 18, 2022 14:03
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from mjcarroll as a code owner October 18, 2022 21:05
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #463 (7722f22) into gz-common5 (b3313c2) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           gz-common5     #463   +/-   ##
===========================================
  Coverage       80.60%   80.60%           
===========================================
  Files              90       90           
  Lines           10237    10237           
===========================================
  Hits             8252     8252           
  Misses           1985     1985           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 1a26b9a into gz-common5 Oct 19, 2022
@mjcarroll mjcarroll deleted the fix_arm_test branch October 19, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants