Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm builds #462

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fix arm builds #462

merged 2 commits into from
Oct 18, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 18, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

ARM doesn't allow narrowing conversions inside {} initializers. See here: https://build.osrfoundation.org/job/gz-common5-debbuilder/786/consoleFull#3015109326ea37b8d-a6d4-40ae-8431-d90c018842af

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from mjcarroll as a code owner October 18, 2022 17:13
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 18, 2022
Signed-off-by: Nate Koenig <[email protected]>
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #462 (8fe74e2) into gz-common5 (5c74a63) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           gz-common5     #462   +/-   ##
===========================================
  Coverage       80.60%   80.60%           
===========================================
  Files              90       90           
  Lines           10235    10237    +2     
===========================================
+ Hits             8250     8252    +2     
  Misses           1985     1985           
Impacted Files Coverage Δ
io/src/CSVStreams.cc 92.15% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @nkoenig !

@nkoenig nkoenig merged commit b3313c2 into gz-common5 Oct 18, 2022
@nkoenig nkoenig deleted the fix_arm_builds branch October 18, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants