Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on case-insensitive filesystems #453

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes build on case-insensitive filesystems, broken by #449

Summary

The fix in #449 accidentally added the autogenerated gz/common/profiler.hh header file, which conflicts with gz/common/Profiler.hh on filesystems that aren't case-sensitive. This adjusts the cmake to avoid installation of that header file, which is not needed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This was unintentionally added in #449 and breaks
compilation on case-insensitive filesystems.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from mjcarroll as a code owner October 11, 2022 18:30
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #453 (29436b9) into ign-common3 (4908754) will not change coverage.
The diff coverage is n/a.

❗ Current head 29436b9 differs from pull request most recent head ce11830. Consider uploading reports for the commit ce11830 to get more accurate results

@@             Coverage Diff              @@
##           ign-common3     #453   +/-   ##
============================================
  Coverage        78.52%   78.52%           
============================================
  Files               72       72           
  Lines             9244     9244           
============================================
  Hits              7259     7259           
  Misses            1985     1985           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit b30c158 into ign-common3 Oct 11, 2022
@mjcarroll mjcarroll deleted the scpeters/fix_profiler_case_insensitive branch October 11, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants