Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #448

Merged
merged 6 commits into from
Oct 11, 2022
Merged

3 ➡️ 4 #448

merged 6 commits into from
Oct 11, 2022

Conversation

mjcarroll
Copy link
Contributor

➡️ Forward port

Port ign-common3 to ign-common4

Branch comparison: ign-common4...ign-common3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

methylDragon and others added 2 commits October 5, 2022 05:55
* Migrate headers

Signed-off-by: methylDragon <[email protected]>

* Add redirection headers

Signed-off-by: methylDragon <[email protected]>

* Migrate include statements

Signed-off-by: methylDragon <[email protected]>

* Leave ignition as primary in headers to fix ABI

Signed-off-by: methylDragon <[email protected]>

* remove comments

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 6, 2022
@mjcarroll mjcarroll changed the title Ports/3 to 4 3 ➡️ 4 Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #448 (5183a5d) into ign-common4 (7d2a40e) will not change coverage.
The diff coverage is 94.44%.

@@             Coverage Diff              @@
##           ign-common4     #448   +/-   ##
============================================
  Coverage        78.92%   78.92%           
============================================
  Files               75       75           
  Lines             9556     9556           
============================================
  Hits              7542     7542           
  Misses            2014     2014           
Impacted Files Coverage Δ
av/include/gz/common/ffmpeg_inc.hh 0.00% <0.00%> (ø)
av/src/AudioDecoder.cc 83.96% <ø> (ø)
av/src/HWEncoder.cc 20.00% <ø> (ø)
av/src/Video.cc 76.98% <ø> (ø)
av/src/VideoEncoder.cc 76.12% <ø> (ø)
av/src/ffmpeg_inc.cc 65.00% <ø> (ø)
events/src/Event.cc 92.59% <ø> (ø)
events/src/KeyEvent.cc 98.11% <ø> (ø)
events/src/MouseEvent.cc 98.88% <ø> (ø)
graphics/src/Animation.cc 95.73% <ø> (ø)
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll self-assigned this Oct 6, 2022
@mjcarroll
Copy link
Contributor Author

Just bumped this with #449 which wasn't included before.

@mjcarroll mjcarroll merged commit 777429d into ign-common4 Oct 11, 2022
@mjcarroll mjcarroll deleted the ports/3_to_4 branch October 11, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants