Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdal to prerequisites #438

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Add gdal to prerequisites #438

merged 1 commit into from
Sep 19, 2022

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 18, 2022

🦟 Bug fix

Summary

From source installation of common5 on Windows according to the tutorial fails to build the geospatial component.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <[email protected]>
@peci1 peci1 requested a review from mjcarroll as a code owner September 18, 2022 00:29
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #438 (31ca274) into gz-common5 (870eaf0) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           gz-common5     #438   +/-   ##
===========================================
  Coverage       80.31%   80.31%           
===========================================
  Files              85       85           
  Lines            9987     9987           
===========================================
  Hits             8021     8021           
  Misses           1966     1966           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 2542907 into gazebosim:gz-common5 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants